[libvirt] [PATCH] libxl: remove unneeded locking of driver when restoring

libxlDomainRestoreFlags acquires the driver lock while reading the domain config from the save file and adding it to libxlDriverPrivatePtr->domains. But virDomainObjList provides self-locking APIs, so remove the needless driver locking. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com&gt; --- I noticed this while working on the recent series to improve event handling in the libxl driver, but it got lost when I reshuffled the patches a bit before sending to the list. src/libxl/libxl_driver.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index b852279..03aa463 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -1956,11 +1956,6 @@ libxlDomainRestoreFlags(virConnectPtr conn, const char *from, return -1; } - /* Lock the driver until domain def is read from the saved - image and a virDomainObj is created and locked. - */ - libxlDriverLock(driver); - fd = libxlSaveImageOpen(driver, cfg, from, &def, &hdr); if (fd < 0) goto cleanup_unlock; @@ -1975,7 +1970,6 @@ libxlDomainRestoreFlags(virConnectPtr conn, const char *from, NULL))) goto cleanup_unlock; - libxlDriverUnlock(driver); def = NULL; ret = libxlVmStart(driver, vm, (flags & VIR_DOMAIN_SAVE_PAUSED) != 0, fd); -- 1.8.1.4