Re: [libvirt PATCH 69/80] qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Finish phase

On Tue, May 10, 2022 at 17:21:30 +0200, Jiri Denemark wrote: > Everything was already done in the normal Finish phase and vCPUs are > running. We just need to wait for all remaining data to be transferred. > > Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com&gt; > --- > src/qemu/qemu_migration.c | 46 ++++++++++++++++++++++++++++++++++----- > 1 file changed, 40 insertions(+), 6 deletions(-) > > diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c > index a8481f7515..430dfb1abb 100644 > --- a/src/qemu/qemu_migration.c > +++ b/src/qemu/qemu_migration.c > @@ -6600,6 +6600,22 @@ qemuMigrationDstFinishFresh(virQEMUDriver *driver, > } > > > +static int > +qemuMigrationDstFinishResume(virQEMUDriver *driver, > + virDomainObj *vm) > +{ > + VIR_DEBUG("vm=%p", vm); > + > + if (qemuMigrationDstWaitForCompletion(driver, vm, > + VIR_ASYNC_JOB_MIGRATION_IN, > + false) < 0) { > + return -1; > + } As I mentioned in another reply, IMO it would be useful to allow adoption of a unattended running migration precisely for this case, so that mgmt apps don't have to encode more logic to wait for events if migration was actually running fine.