Re: [libvirt] [PATCH v5 02/10] qemu: Use domain iothreadids to IOThread's 'thread_id'

... >>>> --- a/src/qemu/qemu_process.c >>>> +++ b/src/qemu/qemu_process.c >>>> @@ -2267,12 +2267,16 @@ qemuProcessDetectIOThreadPIDs(virQEMUDriverPtr driver, >>>> goto cleanup; >>>> } >>> >>> A few lines prior here is the check that the expected thread count >>> equals to the actual thread count. For some reason a few lines before >>> returns success if 0 threads are returned by the monitor. The two checks >>> should be inverted so that it makes sense. >>> >> >> If there are no threads, then it's not a failure, thus change ret to be >> 0. Again, this is something that's not within the scope of this set of >> changes and I believe if necessary could be a followup patch. >> >> I'm not clear on the value of changing the order of the checks. > > The problem is that if there are no iothreads reported by qemu, but we > did request some then it IS failure. > But that's an issue not related to iothreadid's per se - it's a more common general issue that should be a follow-up patch then I think. That is not introduced by this set of changes.

Other issues were addressed changed - do you need to see the diffs or an updated patch with the diffs already squashed in?

John