Re: [libvirt] [jenkins-ci PATCH] projects: switch libvirt-perl over to using Module::Build
On Tue, 2018-05-15 at 16:37 +0100, Daniel P. Berrangé wrote:
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
jobs/perl-makemaker.yaml | 136 -------------------------------------
projects/libvirt-perl.yaml | 6 +-
2 files changed, 3 insertions(+), 139 deletions(-)
delete mode 100644 jobs/perl-makemaker.yaml
diff --git a/jobs/perl-makemaker.yaml b/jobs/perl-makemaker.yaml
deleted file mode 100644
index 84b368e..0000000
--- a/jobs/perl-makemaker.yaml
+++ /dev/null
@@ -1,136 +0,0 @@
-
-- job-template:
- id: perl-makemaker-build-job
- name: '{name}-{branch}-build{variant}'
[...]
- publishers:
- - email:
- recipients: '{obj:spam}'
- notify-every-unstable-build: true
- send-to-individuals: false
This hunk should really be its own commit. Please split it off.
diff --git a/projects/libvirt-perl.yaml b/projects/libvirt-perl.yaml
index 0a6f648..37b48ff 100644
--- a/projects/libvirt-perl.yaml
+++ b/projects/libvirt-perl.yaml
@@ -4,11 +4,11 @@
machines: '{all_machines}'
title: Libvirt Perl
jobs:
- - perl-makemaker-build-job:
+ - perl-modulebuild-build-job:
parent_jobs: 'libvirt-master-build'
- - perl-makemaker-test-job:
+ - perl-modulebuild-test-job:
parent_jobs: 'libvirt-perl-master-build'
test_args: 'TEST_MAINTAINER=1'
test_args will no longer work: you need to replace it with
local_env: |
export TEST_MAINTAINER=1
so that it will be picked up. Which is a better approach to
begin with, hence
https://www.redhat.com/archives/libvir-list/2018-May/msg00691.html
If you take care of all of the above, you can pick up my
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
but you're not quite done yet: you also need to push
https://www.redhat.com/archives/libvir-list/2018-May/msg01171.html
at the same time to ensure all required packages are installed
on the CI workers.
--
Andrea Bolognani / Red Hat / Virtualization