On Wed, Oct 31, 2007 at 01:36:48PM -0400, Daniel Veillard wrote:
On Wed, Oct 31, 2007 at 05:14:10PM +0100, Daniel Hokka Zakrisson
wrote:
> Daniel Veillard wrote:
> >Are the parameters for the scheduler all integers ? If you really
> >never end up with an information set more structured than that then
> >
> > <scheduler fill_rate1='100' interval1='1000'
fill_rate2='25'
> > interval2='1000'
> > idle_time='1'/>
> >
> >would probably be simpler. The question is would other kind of scheduler
> >use more structured parameters ? Seems to me it's not the case and that
> >ad-hoc parsing to convert {name, value} pairs would just work.
>
> Actually, the same settings can be applied to the CPUs separately, e.g.
> <scheduler>
> <param name='fill_rate1'>100</param>
> <param name='interval1'>1000</param>
> <cpu id='0'>
> <param name='idle_time'>1</param>
> <param name='fill_rate2'>25</param>
> <param name='interval2'>1000</param>
> </cpu>
> </scheduler>
> should at some point be possible (it's not in the current patch).
Hum, I see, first time I see such fine grained scheduling, good to
know, thanks !
I still find that
<scheduler fill_rate1='100' interval1='1000'>
<cpu id='0' idle_time='1' fill_rate2='25'
interval2='1000'/>
</scheduler>
would be better than adding the arbitrary <param> element.
I don't think so - it makes it harder for an app to process, since they
need to know the nams of all the backend specific parameters in order
to extract the attribute. By having individual <params> you can easily
access them all with XPath - eg /domain/schedular/param/@name can
give you a list of all param names very nicely. it also maps to the
virSchedInfo data struct nicely
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules:
http://search.cpan.org/~danberr/ -=|
|=- Projects:
http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|