Re: [PATCH 1/3] Makefile: `make check` now computes env variable on the fly
For repos other than the main 'libvirt' repo, we use merge requests on
GitLab.
On a Monday in 2024, Ariel Otilibili wrote:
* env variable used to be Python3.6
* Python3.6 is end of life since December 2021 [1].
[1] https://devguide.python.org/versions/
Signed-off-by: Ariel Otilibili <otilibil(a)eurecom.fr>
---
Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index b08e2bd..1cab66c 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,7 @@
# Shim wrapper around setup.py to allow for familiar build targets
PYTHON ?= python
+VERSION := $(shell $(PYTHON) -V | perl -nE 'print "$$1$$2" if
/\s(\d+)\.(\d+)/')
Please, no Makefile-escaped perl. Python should be able to do it too:
python -c 'import sys; print("{}{}".format(sys.version_info.major,
sys.version_info.minor))'
all:
$(PYTHON) -m build
@@ -12,7 +13,7 @@ clean:
rm -rf build/ dist/
check: all
- tox -e py36
+ tox -e py$(VERSION)
If I understand correctly, the point of tox is to run the test suite
against different Python versions.
Having 'py36' hardcoded here made sure it worked against that particular
version even if the user has a different version, but I do not
understand the benefit of running it against the current version (as
opposed to just running pytest directly).
Jano
test: all
tox
--
2.45.2
Attachments:
- signature.asc (application/pgp-signature — 228 bytes)