Re: [Libvir] [PATCH] Fix value of XEN_V2_OP_SETMAXMEM
On Mon, Mar 26, 2007 at 09:24:27AM +0900, Masayuki Sunou wrote:
Hi
Because the value of XEN_V2_OP_SETMAXMEM in xen_internal.c is wrong, virsh
setmaxmem outputs error message.
--> Both XEN_V2_OP_SETMAXMEM and XEN_V2_OP_GETVCPUINFO are set to 14, but
XEN_V2_OP_SETMAXMEM should be set to 11.
Ohh, right, now that explain the strange error message:
paphio:~/libvirt -> grep -i max_mem /usr/include/xen/*.h | grep 11
/usr/include/xen/domctl.h:#define XEN_DOMCTL_max_mem 11
paphio:~/libvirt ->
Applied and commited, thanks !
Once applied I checked all the values against the original ones from
/usr/include/xen/domctl.h , they look fine now
paphio:~/libvirt -> grep 'define XEN_V2_OP_' src/xen_internal.c
#define XEN_V2_OP_GETDOMAININFOLIST 6
#define XEN_V2_OP_DESTROYDOMAIN 2
#define XEN_V2_OP_PAUSEDOMAIN 3
#define XEN_V2_OP_UNPAUSEDOMAIN 4
#define XEN_V2_OP_SETMAXMEM 11
#define XEN_V2_OP_SETMAXVCPU 15
#define XEN_V2_OP_SETVCPUMAP 9
#define XEN_V2_OP_GETVCPUINFO 14
#define XEN_V2_OP_GETVCPUMAP 25
paphio:~/libvirt ->
only XEN_V2_OP_GETDOMAININFOLIST is actually a sysop operation and
defined in a different header file:
/usr/include/xen/sysctl.h:#define XEN_SYSCTL_getdomaininfolist 6
thanks a lot !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/