Re: [libvirt] [PATCH v2 4/5] qemu: Add QEMU_CAPS_SDL_GL to qemu capabilities
On Fri, May 11, 2018 at 03:14:26PM +0100, Maciej Wolny wrote:
On 11/05/18 11:34, John Ferlan wrote:> I actually spent some time
trying to figure out which magic incantation
> of the virQEMUCaps* would work. I even tried various forms in
> virQEMUCapsQMPSchemaQueries, but could not get the flag to be added from
> qemu 2.4 and beyond. Again, my "assumption" is that it was hand edited
> into the 2.4 replies that was added here mainly because none of the
> other available sdl * options were addressed - just the one that was wanted.
It was hand-edited. I'm still not sure how this work.. I ran the tool to
generate a .replies file; but based on that, how do I get the replies for
all historical version of QEMU, do I need to have each of the versions of
QEMU installed on my system.
Unfortunately, yes. There was some work done so taht we could automate that,
but nobody actually finished the work. Anyway, since QEMU does not expose that
capability in the QMP communication (what libvirt uses to check for the
support), we need to guess it based on the release version :(
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)