Re: [libvirt] [PATCH v5] automatic create tap device with network type ethernet
On 12.12.2014 14:09, Vasiliy Tolstov wrote:
2014-12-10 17:34 GMT+03:00 Vasiliy Tolstov
<v.tolstov(a)selfip.ru>:
> If user not specify network type ethernet, assume that user
> needs simple tap device created with libvirt.
> This patch does not need to run external script to create tap device or
> add root to qemu process. Also libvirt runs script after device creating,
> if user provide it.
>
> Signed-off-by: Vasiliy Tolstov <v.tolstov(a)selfip.ru>
>
Does it possible to include this in current planned libvirt release?
Thanks
Well, while trying to review the patch, it seems like you haven't sent
rebased version. I mean, Laine pushed a patchset on Dec 8, that reworks
qemuNetworkIfaceConnect() so that it's called only on a few occasions.
However, the patch you've sent on Dec 10 doesn't even apply cleanly. I
had to go to before his patches to be able to apply it cleanly. However,
since the function semantics has changed since then, can you rebase to
the current HEAD and resend? Thanks!
Michal