Re: [libvirt] [PATCH 3/9] s/int/virLogDestination/ in logging code

On 09/27/2012 10:44 AM, Daniel P. Berrange wrote: ACK. This time, no testsuite failure, but I'd still suggest squashing this in before pushing, since '0' is not a valid virLogDestination: diff --git i/tests/testutils.c w/tests/testutils.c index a85f560..e144d33 100644 --- i/tests/testutils.c +++ w/tests/testutils.c @@ -610,7 +610,7 @@ int virtTestMain(int argc, virLogSetFromEnv(); if (!getenv("LIBVIRT_DEBUG") && !virLogGetNbOutputs()) { if (virLogDefineOutput(virtTestLogOutput, virtTestLogClose, &testLog, - VIR_LOG_DEBUG, 0, NULL, 0) < 0) + VIR_LOG_DEBUG, VIR_LOG_TO_STDERR, NULL, 0) < 0) return 1; } -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org