Re: [libvirt] [PATCH] Use sys/uio.h for writev()
On Wed, Jun 14, 2017 at 03:50:22PM +0200, Martin Kletzander wrote:
On Wed, Jun 14, 2017 at 02:39:27PM +0100, Daniel P. Berrange wrote:
> With glibc >= 2.25.90 writev() is only available if you explicitly
> include sys/uio.h
>
> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
> ---
>
> A build breaker, but not yet pushed in case anyone has opinions...
>
Even older ones require that, actually, so we should've done that even
before. I'm not sure we need to include it conditionally, but ACK to
this version.
Oh I added the conditional because its missing in Mingw, but I forgot
that gnulib fixes that for us. So yeah, I'll remove the conditional.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|