Re: [libvirt] [PATCH] fix MinGW compilation(200808)

"Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: >> If you don't object, I'll go for the simpler interface (and smaller >> change). However I've just noticed that that will require an adjustment >> of the gnulib license for the inet_pton module. But that shouldn't be >> a problem, since the code in question is glibc-derived. > > Yep, fine by me. Ok. Here's the complete patch, including the new file from gnulib. I've verified that a freshly-cloned directory passes ./autogen && make && make check Ha! But it failed "make syntax-check" due to the use of ctype's tolower in inet_pton.c. I'm fixing that in gnulib now, since it can/should be c_tolower. Here's the fix prior to the s/tolower/c_tolower/ inet_pton.c change (it also does s/<ctype/<c-ctype/). I'll wait until gnulib is fixed before committing here.