Re: [libvirt] [PATCH 1/2] virsh: list required options first

On Tue, Apr 12, 2011 at 15:35:06 -0600, Eric Blake wrote: > The current state of virsh parsing is that: > > all lookup the volume by path (technically, the last two also attempt > a name lookup within a pool, whereas the first skips that step, but > the end result is the same); meanwhile: Is example virsh command line missing here?

> * tools/virsh.c (opts_vol_create_from, opts_vol_clone) > (opts_vol_upload, opts_vol_download, opts_vol_delete) > (opts_vol_wipe, opts_vol_info, opts_vol_dumpxml, opts_vol_key) > (opts_vol_path): List optional pool parameter after required > arguments. > --- > tools/virsh.c | 20 ++++++++++---------- > 1 files changed, 10 insertions(+), 10 deletions(-) Makes sense. I went through all virsh.c and didn't find more options that would need fixing. The only options which don't follow this "optional after required" rule are bool options which can safely stay where they are. ACK