Re: [libvirt] [PATCH 3/4] snapshot: take advantage of new relations

> + if (!(flags& VIR_DOMAIN_SNAPSHOT_LIST_ROOTS)) { > + virHashForEach(snapshots->objs, virDomainSnapshotObjListCount,&data); > + } else if (data.flags) { > + virDomainSnapshotObjPtr root = snapshots->first_root; > + while (root) { > + virDomainSnapshotObjListCount(root, root->def->name,&data); > + root = root->sibling; > + } I was just wondering if a data structure with a meta-root snapshot and unifying first_root as a first_children on that meta-root wouldn't lead to simpler code overall.