Re: [libvirt] [PATCH] iscsi: do not fail to stop a stopped pool

Just as we allow stopping filesystem pools when they were unmounted externally, do not fail to stop an iscsi pool when someone else closed the session externally. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1171984 --- src/storage/storage_backend_iscsi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c index 197d333..bea6758 100644 --- a/src/storage/storage_backend_iscsi.c +++ b/src/storage/storage_backend_iscsi.c @@ -449,8 +449,13 @@ virStorageBackendISCSIStopPool(virConnectPtr conn ATTRIBUTE_UNUSED, virStoragePoolObjPtr pool) { char *portal; + char *session; int ret = -1; + if ((session = virStorageBackendISCSISession(pool, false)) == NULL)

+ return 0; + VIR_FREE(session); +

if ((portal = virStorageBackendISCSIPortal(&pool->def->source)) == NULL) return -1; -- 2.0.5 -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list