Re: [libvirt] [PATCH 1/2] seclabel: Do not output relabel attribute for type 'none'

On 02/07/2012 01:10 PM, Jiri Denemark wrote: > Security label type 'none' requires relabel to be set to 'no' so there's > no reason to output this extra attribute. Moreover, since relabel is > internally stored in a negative from (norelabel), the default value for > relabel would be 'yes' in case there is no <seclabel> element in domain > configuration. In case VIR_DOMAIN_SECLABEL_DEFAULT turns into > VIR_DOMAIN_SECLABEL_NONE, we would incorrectly output relabel='yes' for > seclabel type 'none'. > --- > src/conf/domain_conf.c | 9 +++++---- > .../qemuxml2argv-seclabel-none.xml | 2 +- > 2 files changed, 6 insertions(+), 5 deletions(-) ACK.