[libvirt] Scope of the test driver? (Was: Re: [PATCH] test_driver: implement virDomainSendKey)

On Mon, Jun 03, 2019 at 08:52:55 +0200, Erik Skultety wrote: [...] I think the problem here is that it's unclear what the purpose of the test driver is supposed to be. Clarifying the purpose first might have positive impact on the design decisions here. So what's the point of the test driver? Is it meant for human interaction, e.g. for application developers or users wanting to test stuff? In that case you probably want to simulate the "worst" behaviour we have, which would be the blocking timeout so that users/devs can see the worst case implications of running such a command. Alternatively the purpose may be to allow some kind of "unit" testing for APPs using libvirt. (I specifically used "unit" testing, because any kind of sane real integration testing will not use the test driver because it would not accomplish much). In such case the timeout is a hassle because it just unnecessarily prolongs test runs and does not add much value. Any other ideas? I don't have any more. Frankly even the two use cases above aren't something I'd recommend to the users. In case of user/dev testing, checking against a real VM makes more sense and the same goes for real integration testing.