Re: [libvirt] [PATCH python 1/1] Set hints for virPyDictToTypedParams
On Mon, Feb 19, 2018 at 02:20:30PM +0100, Pavel Hrdina wrote:
On Mon, Feb 19, 2018 at 01:09:27PM +0000, Daniel P. Berrangé wrote:
> On Wed, Feb 07, 2018 at 05:49:30PM +0300, Edgar Kaziakhmedov wrote:
> > Predefine hints for all parameters possible to avoid wrong type
> > convert.
> >
> > Signed-off-by: Edgar Kaziakhmedov <edgar.kaziakhmedov(a)virtuozzo.com>
> > ---
> > libvirt-override.c | 128
+++++++++++++++++++++++++++++++++++++++++++++++++++--
> > 1 file changed, 124 insertions(+), 4 deletions(-)
>
> Thanks, looks good, so I've pushed this now.
Actually I wanted to suggest to use static variables to store the hints:
If you want to send a followup todo that its fine by me...
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|