Re: [libvirt] [PATCH] qemu: handle not supported writable devices
Hello Eric,
Am Freitag 15 Februar 2013, 17:26:30 schrieb Eric Blake:
On 02/15/2013 07:13 AM, Philipp Hahn wrote:
> If the running VM contains a writable raw image, creating snapshot fails
> internally in QEMU, but the error is not detected by libvirt. Success is
> still reported to the user, who will see the snapshot in libvirt, even
> they are NOT created by qemu.
Libvirt is supposed to already have code that refuses an internal
snapshot on non-qcow2 files. We must have broken this somewhere in the
recent past. It would be nice to figure out why
qemuDomainSnapshotPrepare() is failing to do a proper job before we take
this patch. :(
Okay, that might be my problem: I'm working on the old Debian version
0.9.12-5, where that code might not yet be available. I patched it there and
forward-ported that patch to current git, because there the check was also
missing.
(Perhaps even better would be to return an error by default and only return
rv=0, when _no_ output is returned by the command)
Sincerely
Philipp
--
Philipp Hahn Open Source Software Engineer hahn(a)univention.de
Univention GmbH be open. fon: +49 421 22 232- 0
Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99
http://www.univention.de/