Re: [libvirt] PATCH: Pass -name argument to QEMU

On Tue, May 13, 2008 at 12:21:02AM +0100, Daniel P. Berrange wrote: > This patch makes libvirt pass the -name argumet to QEMU it if it supported > by the QEMU binary in question. THis allows QEMU to set the VNC title and > allows Xenner to set the Xen guest name in xenstore. Fine by me, +1 > @@ -2348,6 +2350,7 @@ > len = 1 + /* qemu */ > 2 + /* machine type */ > disableKQEMU + /* Disable kqemu */ > + (vm->qemuCmdFlags & QEMUD_CMD_FLAG_NAME ? 2 : 0) + /* -name XXX */ > 2 * vm->def->ndisks + /* disks*/ > (vm->def->nnets > 0 ? (4 * vm->def->nnets) : 2) + /* networks */ > 1 + /* usb */ > @@ -2394,6 +2397,12 @@ I just start to find that arg length computation a bit long and messy. As we add the args maybe it's time to do that a bit more dynamically, no ?