Re: [libvirt] [PATCH 00/14] Clean up spec files mess
Mark McLoughlin wrote:
Hey,
I get treated like a war criminal when I make a change in the
Fedora spec file and don't send it upstream, yet there are a whole
heap of changes which haven't been pushed upstream ... only one of
which is mine ... two changes less than DV himself :-)
The following series of patches pulls in the changes from
Fedora which make sense. Some of them I'm not 100% sure of:
- defaulting to policy kit - is there some reason we don't
want that upstream?
- The python cruft thing, not sure its needed
- Converting NEWS to UTF-8 could probably be done upstream
- Requiring libselinux is dubious, doesn't autorequires handle
that?
That's my fault. I added that to the fedora spec in the F11 time frame. On a
fresh rawhide install, libvirt wouldn't start because libselinux wasn't pulled
in. I later realized that my install was just hosed in some manner, but I had
already pushed the spec file change.
So that dependency can probably be dropped.
- Cole