Re: [libvirt] [PATCH] cgroup: Enable memory.use_hierarchy of cgroup for domain

> +            if (memory_hierarchy && > +                group->controllers[VIR_CGROUP_CONTROLLER_MEMORY].mountPoint != NULL && > +                (i == VIR_CGROUP_CONTROLLER_MEMORY || > +                 STREQ(group->controllers[i].mountPoint, group->controllers[VIR_CGROUP_CONTROLLER_MEMORY].mountPoint))) { > +                rc = virCgroupSetMemoryUseHierarchy(group); > +                if (rc != 0) { > +                    VIR_FREE(path); > +                    break; > +                } > +            } >         } > >         VIR_FREE(path); > @@ -553,7 +594,7 @@ static int virCgroupAppRoot(int privileged, >     if (rc != 0) >         goto cleanup; > > -    rc = virCgroupMakeGroup(rootgrp, *group, create); > +    rc = virCgroupMakeGroup(rootgrp, *group, create, 0); > >  cleanup: >     virCgroupFree(&rootgrp); > @@ -653,7 +694,7 @@ int virCgroupForDriver(const char *name, >     VIR_FREE(path); > >     if (rc == 0) { > -        rc = virCgroupMakeGroup(rootgrp, *group, create); > +        rc = virCgroupMakeGroup(rootgrp, *group, create, 0); >         if (rc != 0) >             virCgroupFree(group); >     } > @@ -703,7 +744,7 @@ int virCgroupForDomain(virCgroupPtr driver, >     VIR_FREE(path); > >     if (rc == 0) { > -        rc = virCgroupMakeGroup(driver, *group, create); > +        rc = virCgroupMakeGroup(driver, *group, create, 1); >         if (rc != 0) >             virCgroupFree(group); >     } A comment on why Domains get hierarchy support and Drivers don't will help unless it is very obvious to developers.