Re: [libvirt] [PATCH v2] python: add virDomainGetCPUStats python binding API

>> + if (totalbool == Py_False) { > Per other code in libvirt-override.c, you can't compare totalbool (type > PyObject) with Py_False, at least not on all compilers. You need > something like this instead: > > /* Hack - Python's definition of Py_True breaks strict > * aliasing rules, so can't directly compare > */ > if (PyBool_Check(value)) { > PyObject *hacktrue = PyBool_FromLong(1); > temp->value.b = hacktrue == value ? 1 : 0; > Py_DECREF(hacktrue); Yes, it did report warning in compiling as follows due to the case from PyIntObject* to PyObject* warning :dereferencing type-punned pointer might break strict-aliasing rules [-Wstrict-aliasing]

GCC command line to reproduce the error: gcc -Wstrict-aliasing=1 -O2 cpythonexample.c Actually PyObject_IsTrue() is a more light-weight approach to do the checking instead of creating a intermediate PyObject * for the compare.