Re: [libvirt] PATCH: 2/11: Move internal error APIs into virterror_internal.h
On Thu, Oct 30, 2008 at 03:19:11PM +0100, Daniel Veillard wrote:
On Thu, Oct 30, 2008 at 01:36:10PM +0000, Daniel P. Berrange wrote:
> After Daniel's feedback that adding src/virterror.h is confusing, I've
> re-done the patch to instead add virterror_internal.h, making it clear
> that these function prototypes are related to virterror.c, but internal
> use only. That patch is basically moving them out of src/internal.h
> In addition it removes the leading __ prefix from virRaiseError since
> this symbol was never exported fromthe library.
>
> The diff is mis-leading - most of this is just the s/__// change.
Okay, I'm surprized that there is no more usage of internal.h, i would
have though it was still used widely for things like ATTRIBUTE_UNUSED, but
apparently not,
Actually, that's just a minor simplification on my part - virterror_internal.h
will include internal.h, so there was no need to keep the explicit internal.h,
though we could if you wanted. Ultimately every single file uses the
internal.h, via one or more of its includs.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|