Re: [libvirt] [PATCH] vircgroupmock.c: Avoid crashing if lstat() not found
On Thu, Oct 17, 2013 at 03:33:36PM +0200, Michal Privoznik wrote:
In init_syms() we admit that stat() may not exists (in favor of
existing
__lxstat). However, if previously an library checked for existence of
these two symbols and wisely has chosen the existing one, now, that we've
mocked the both symbols, we are confusing the library. Moreover, such
library will get SIGSEGV immediately after wrong decision, since
reallstat is NULL.
I don't really get what you're trying to say here. If lstat() doesn't
exist in the libraries we're linking to, then our lstat() wrapper should
not be called either. Also, what platform do you see a crash on.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|