Re: [libvirt] [PATCH v2 2/4] virnetdev: Introduce virNetDevGetLinkInfo

>> +{ >> + int ret = -1; >> + char *path = NULL; >> + char *buf = NULL; >> + char *tmp; >> + int tmp_state; > > s/int/virInterfaceState/ > In fact this is intentional. Remember Eric's TypeFromString() patches? The problem is, one can't be sure if compiler decides on using unsigned or signed integer to represent an enum. If it decides to use an unsigned int (IIRC that's the case of older gcc) then comparison a few lines below will never be true.