Re: [libvirt] [PATCH 0/4] Move ccwaddrs and pciaddrs to domainDef
On 06/19/2016 08:18 PM, Tomasz Flendrich wrote:
This patch depends on another one, because it was created on top
of the changes in the other one. Link to the dependency:
https://www.redhat.com/archives/libvir-list/2016-June/msg01227.html
This is the next patch of the ongoing process of abstracting device
address generation.
In this patch, addres sets are moved from QEMU's (ccw and pci)
and bhyve's (pci only) private data to domainDef. In the future,
it's likely that more hypervisors will add the feature of explicitly
specifying the device addresses, so handling the addresses should be
made more generic.
Apologies if I'm missing something, I didn't look too closely at this series,
however have you seen this thread?
http://www.redhat.com/archives/libvir-list/2016-May/msg01071.html
My understanding of the current code is that the cached vioserial/ccw/pciaddrs
lists in qemu aren't actually required... they were at one point to handle
older qemu, but we dropped that support. Maybe you can pick up my patches and
finish off dropping of pciaddrs and ccwaddrs? I suspect the pciaddrs cache in
bhyve can be dropped as well, I don't think it was ever strictly required, the
code just followed the qemu example
That said I think it makes sense in general to move this generic stuff out of
qemu since it's generic code as you say, but better to remove the obsolete
stuff first IMO
Thanks,
Cole