Re: [libvirt] [PATCH 2/7] Add support for storage format in FS <driver>
On 03/15/2013 12:32 PM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange(a)redhat.com>
Extend the <driver> element in filesystem devices to
allow a storage format to be set. The new attribute
uses 'format' to reflect the storage format. This is
different from the <driver> element in disk devices
which use 'type' to reflect the storage format. THis
s/THis/This
is because the 'type' attribute on filesystem devices
is already used for the driver backend, for which the
disk devices use the 'name' attribte. Arggggh.
s/attribte/attribute
Your call on the Arggggh
Anyway for disks we have
<driver name="qemu" type="raw"/>
And for filesystems this change means we now have
<driver type="loop" format="raw"/>
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
---
docs/formatdomain.html.in | 24 ++++++++++++++
docs/schemas/domaincommon.rng | 73 ++++++++++++++++++++++++++++++-------------
src/conf/domain_conf.c | 25 ++++++++++++---
src/conf/domain_conf.h | 6 ++--
src/qemu/qemu_command.c | 3 +-
5 files changed, 102 insertions(+), 29 deletions(-)
ACK
Although the rng defs are still a bit of black magic to me.
I suppose one could say the <driver element options could be better
described with respect to their possible/valid options in both the hard
drives/floppy disks/cdroms and filesystems section of the documentation.
With your new description you list since 1.0.4 for the driver element,
but it seems using driver was available before that and the new 1.0.4
addition is the loop/format options. At least that's how I read it.
John