[libvirt] [RFC, PATCH] Re: xen:/// vs. xen://FQDN/ vs xen+unix:/// discrepancy

Hello, Am Freitag 23 Juli 2010 18:02:27 schrieb Philipp Hahn: ... Today I encountered the bug again: "virsh list" was not showing any domain, while "virsh -c xen+unix:///" did show "Domain 0" and my other domain. I attached gdb, "thread apply all bt" showed no thread still executing xenHypervisorInit(), but I found the following inconsistent state: Notice in_init=1: Currently there are two error path, where that can happen: 1. ret = open(XEN_HYPERVISOR_SOCKET, O_RDWR); 2. if (VIR_ALLOC(ipt) < 0) { In both cases in_init remains 1, which disables further useful logging: This leads me to the following question: 1. Why is error reporting deactivated during init? Since in_init==1 is valid only during the call xenHypervisorInit(), explicitly using that macro there for logging seems very wrong. 2. xenHypervisorInit() also allocates three regexp_t structures, which are only freed when one of them can not be compiled, but they remain in memory when determin the Xen hypervisor version fails. On the other hand these 3 structures are used in xenHypervisorMakeCapabilitiesInternal(). This isn't checked directly, but only indirectly, because in the error case no one will ever call it with a valid virConnectPtr. Should the structures be freed in all error cases? The attached patch is a first try at improving that situation. This didn't work because of the bug described above. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer hahn(a)univention.de Univention GmbH Linux for Your Business fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http://www.univention.de/