Re: [libvirt] [PATCH v2 0/3] pass the path of compress prog directly
>
> BTW: Patch 2 fails syntax-check
>
I make syntax-check again and passed on a centos7 machine.
Maybe it's a syntax-check bug?
Don't think so...
cppi: src/qemu/qemu_driver.c: line 3269: not properly indented
maint.mk: incorrect preprocessor indentation
cfg.mk:680: recipe for target 'sc_preprocessor_indentation' failed
make: *** [sc_preprocessor_indentation] Error 1
make: *** Waiting for unfinished jobs....
Line 3269:
# define VIR_QEMU_COMPRESS_CHECK(val, type)
\
do {
\
if (cfg->val) {
...
If the "# define" is changed to "#define", then the syntax-check
passes.
The usage of "# define" is done/allowed with an "#if" or
"#ifdef" type
construct in order to 'mark' that we're within some sort of preprocessor
condition.
Additionally those lines are too long - use 80 character columns
John