Re: [PATCH 1/2] qemu: Autofill pstore path if missing

On Mon, Jul 29, 2024 at 11:31:35AM GMT, Michal Privoznik wrote: > Introduced only a couple of commits ago (in > v10.5.0-84-g90e50e67c6) the pstore device acts as a nonvolatile > storage, where guest kernel can store information about crashes. > This device, however, expects a file in the host from which the > crash data is read. So far, we expected users to provide a path, > but we can autogenerate one if missing. Just put it next to > per-domain's _NVRAM stores. Either s/_NVRAM/_VARS/ or lose the leading underscore. You also need to squash in the diff below. With the latter taken care of, Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt; diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 860ef17d7b..c56b739b23 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -8683,8 +8683,7 @@ desired backend (only ``acpi-erst`` is accepted for now). Then it has the following child elements: ``path`` - Represents a path in the host that backs the pstore device in the guest. It - is mandatory. + Represents a path in the host that backs the pstore device in the guest. ``size`` Configures the size of the persistent storage available to the guest. It is diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincommon.rng index 6fcee2a70c..7d58dce465 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -6261,9 +6261,11 @@ <value>acpi-erst</value> </attribute> <interleave> - <element name="path"> - <ref name="absFilePath"/> - </element> + <optional> + <element name="path"> + <ref name="absFilePath"/> + </element> + </optional> <element name="size"> <ref name="scaledInteger"/> </element>