Re: [libvirt] [PATCH 12/26] conf: Parse and format <target index='...'/>
On Tue, 2017-06-13 at 17:59 -0400, Laine Stump wrote:
> @@ -9155,6 +9158,23 @@ virDomainControllerDefParseXML(xmlNodePtr
node,
> goto error;
> }
> }
> + if (idx) {
> + if (virStrToLong_i(idx, NULL, 0,
> + &def->opts.pciopts.idx) < 0) {
> + virReportError(VIR_ERR_XML_ERROR,
> + _("Invalid index '%s' in PCI
controller"),
You should probably say "target index" to differentiate it from the
toplevel index.
I agree and was in fact planning to change it just the way
you suggested, I just forgot O:-)
Other than that, what about an xml2xml test case? (as well as
combining
with the previous patch, and adding a sentence to formatdomain.html.in)
Test cases (both argv2xml and xml2xml) are added in patch
19/26, that is, after adding the code that fills in the
target index automatically. I'd prefer keeping it that way
so that they excercise the entire functionality at once.
--
Andrea Bolognani / Red Hat / Virtualization