Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events
On Fri, Jan 31, 2014 at 07:12:08PM -0700, Eric Blake wrote:
Create qemu monitor events as a distinct class to normal domain
events, because they will be filtered differently. For ease of
review, the logic for filtering by event name is saved for a later
patch.
* src/conf/domain_event.c (virDomainQemuMonitorEventClass): New
class.
(virDomainEventsOnceInit): Register it.
(virDomainQemuMonitorEventDispose, virDomainQemuMonitorEventNew)
(virDomainQemuMonitorEventDispatchFunc)
(virDomainQemuMonitorEventStateRegisterID): New functions.
* src/conf/domain_event.h (virDomainQemuMonitorEventNew)
(virDomainQemuMonitorEventStateRegisterID): New prototypes.
* src/libvirt_private.syms (conf/domain_conf.h): Export them.
---
src/conf/domain_event.c | 140 +++++++++++++++++++++++++++++++++++++++++++++++
src/conf/domain_event.h | 22 ++++++++
src/libvirt_private.syms | 2 +
3 files changed, 164 insertions(+)
I think these APIs should be in src/qemu/qemu_event.{c,h} rather
than in the shared codebase. I think it ought to be possible to
split the code off, since we've already done separation of the
network + domain events + base object evemt classes into distinct
files.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|