Re: [libvirt] [PATCH 18/18] tests: Add a bunch of ppc64 cases to the cpu test
On Fri, 2015-08-07 at 10:14 +0200, Jiri Denemark wrote:
According to our discussion sometime last week I think PPC64 driver
should never create a CPU definition with fallback='allow' since it
doesn't make any sense for PPC. In other words, this series is
missing
one patch that would make sure all CPU defs created by PPC driver
honor
this.
Otherwise looks good, although you will need to add more tests making
sure we stay compatible with the old versioned CPU models.
I've just posted a v2 that covers these and all the other
points you've raised during the review / we've discussed.
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team