Re: [PATCH] network: fix check in virNetworkLoadConfig

On Wed, Dec 06, 2023 at 21:30:59 +0300, Anastasia Belova wrote: This statement is not true: #define SAME_INODE(Stat_buf_1, Stat_buf_2) \ ((Stat_buf_1).st_ino == (Stat_buf_2).st_ino \ && (Stat_buf_1).st_dev == (Stat_buf_2).st_dev) /* Return nonzero if checkLink and checkDest * refer to the same file. Otherwise, return 0. */ int virFileLinkPointsTo(const char *checkLink, const char *checkDest) { struct stat src_sb; struct stat dest_sb; return (stat(checkLink, &src_sb) == 0 && stat(checkDest, &dest_sb) == 0 && SAME_INODE(src_sb, dest_sb)); } Based on the docs and the code virFileLinkPointsTo returns 'true' typecast to int (thus non-zero) on success, if the ling (1st arg) points to the second arg. Otherwise if the state can't be determined or the linking doesn't exist it returns false, thus 0. Thus doing this would cause to always bail out as if it were failure if the link points to the expected file. In fact the original behaviour, which would be that the condition is always false => dead code was correct, and the condition should be removed. 'autostart' can be filled unconditionally. In fact for a proper fix virFileLinkPointsTo should be also converted to return bool.