Re: [libvirt PATCH 6/9] spec: Move _vpath_builddir definition
On Tue, 2020-10-06 at 07:51 -0400, Neal Gompa wrote:
On Tue, Oct 6, 2020 at 6:28 AM Andrea Bolognani
<abologna(a)redhat.com> wrote:
> We're installing Meson from PyPi instead of EPEL on CentOS as part of
> our CI setup, but indeed it looks like that's not necessary and we
> could simply use the EPEL package. I'll look into that.
>
> Anyway, at least on my Fedora machine _vpath_builddir is defined in
> /usr/lib/rpm/macros.d/macros.vpath, which is part of the
> redhat-rpm-config package, and the various %meson macros defined in
> /usr/lib/rpm/macros.d/macros.meson use it, so it doesn't look like
> even installing Meson from EPEL would remove the need to define that
> value? Note I haven't actually tried O:-)
In EPEL 7, the %_vpath_* macros are defined by epel-rpm-macros, which
are installed automatically into the build environment when you do a
package build. We could just have this installed in our CentOS 7 CI
environment.
Looks like that package doesn't get pulled into container images, so
we're going to need to add it explicitly. Doing so makes sense,
considering that we're already pulling ninja from EPEL and you can't
build libvirt without ninja these days.
I'll open a MR against libvirt-ci soon.
--
Andrea Bolognani / Red Hat / Virtualization