Re: [libvirt] PATCH: 12/25: Remove global state from Inotify driver
On Tue, Jan 13, 2009 at 05:43:38PM +0000, Daniel P. Berrange wrote:
The 'inotify' driver currently keeps all its state in a
global static
variables. Not so great since we access this from all sorts of places
and its hard to guarentee thread safety. Also, we're using per-connection
FD watches to update this state, so if multiple Xen connections were
active, they'd all be updating the same globl state. So we move the
state into the virConnect object. This will increase memory usage if
a single process has multiple Xen connections open though, but not
by very much
I'm not really familiar with this code. It seems reasonable, but I'll
let someone else check it. Just to say ...
- if (!memcmp(uuid, configInfoList->doms[i]->uuid,
VIR_UUID_BUFLEN)) {
memcmp (...) == 0
or define a new equality test macro?
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/