Re: [libvirt] [PATCH] net: merge virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC
On Fri, Jun 27, 2014 at 09:45:09AM +0200, Peter Krempa wrote:
On 06/26/14 17:29, Ján Tomko wrote:
> On 06/26/2014 04:51 PM, Peter Krempa wrote:
>> Instead of maintaining two very similar APIs, add the "@mac"
parameter
>> to virNetworkGetDHCPLeases and kill virNetworkGetDHCPLeasesForMAC. Both
>> of those functions would return data the same way, so making @mac an
>> optional filter simplifies a lot of stuff.
[...]
> ACK with the debug message added and virsh functionality fixed.
>
> Jan
>
I've resolved all your comments and pushed this patch.
Thanks
Not finished, this now break the libvirt-python build which expects
virNetworkGetDHCPLeasesForMAC to be in the exported set of function,
so a bit of cleanup is needed there, preferably before the release :-)
Daniel
--
Daniel Veillard | Open Source and Standards, Red Hat
veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | virtualization library http://libvirt.org/