Re: [libvirt] [PATCH] remove sysfs_path and parent_sysfs_path from XML

On Wed, Nov 18, 2009 at 05:32:54PM -0500, Dave Allan wrote: > I erroneously included the sysfs_path and parent_sysfs_path elements in > the node device xml. The attached patch removes them. > > Dave > >From d848b0c5d9c92546e95c081eb7ca185101d71507 Mon Sep 17 00:00:00 2001 > From: David Allan <dallan(a)redhat.com&gt; > Date: Wed, 18 Nov 2009 17:29:35 -0500 > Subject: [PATCH 1/1] Remove sysfs_path and parent_sysfs_path from XML > > * These two elements were included erroneously in the udev backend commit > --- > src/conf/node_device_conf.c | 8 -------- > 1 files changed, 0 insertions(+), 8 deletions(-) > > diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c > index add9d2b..4a15644 100644 > --- a/src/conf/node_device_conf.c > +++ b/src/conf/node_device_conf.c > @@ -251,17 +251,9 @@ char *virNodeDeviceDefFormat(virConnectPtr conn, > > virBufferAddLit(&buf, "<device>\n"); > virBufferEscapeString(&buf, " <name>%s</name>\n", def->name); > - if (def->sysfs_path != NULL) { > - virBufferEscapeString(&buf, " <sysfs_path>%s</sysfs_path>\n", > - def->sysfs_path); > - } > if (def->parent) { > virBufferEscapeString(&buf, " <parent>%s</parent>\n", def->parent); > } > - if (def->parent_sysfs_path != NULL) { > - virBufferEscapeString(&buf, " <parent_sysfs_path>%s</parent_sysfs_path>\n", > - def->parent_sysfs_path); > - } > if (def->driver) { > virBufferAddLit(&buf, " <driver>\n"); > virBufferEscapeString(&buf, " <name>%s</name>\n", def->driver); IIRC that was a cleanup asked by Dan during his review, in any case it's showing up at the API level so please cleanup before the release, ACK