Re: [libvirt] [PATCH v3 06/10] Add capability to fetch balloon stats

This patch will add the qemuMonitorJSONGetMemoryStats() to execute a "guest-stats" on the balloonpath using "get-qom" replacing the former mechanism which looked through the "query-ballon" returned data for the fields. The "query-balloon" code only returns 'actual' memory. Rather than duplicating the existing code, have the JSON API use the GetBalloonInfo API. A check in the qemuMonitorGetMemoryStats() will be made to ensure the balloon driver path has been set. Since the underlying JSON code can return data not associated with the balloon driver, we don't fail on a failure to get the balloonpath. Of course since we've made the check, we can then set the ballooninit flag. Getting the path here is primarily due to the process reconnect path which doesn't attempt to set the collection period. --- src/qemu/qemu_monitor.c | 10 ++- src/qemu/qemu_monitor_json.c | 190 ++++++++++++++++++++----------------------- src/qemu/qemu_monitor_json.h | 1 + 3 files changed, 95 insertions(+), 106 deletions(-)

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index a3e250c..14b80e3 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -1483,10 +1483,14 @@ int qemuMonitorGetMemoryStats(qemuMonitorPtr mon, return -1; } - if (mon->json) - ret = qemuMonitorJSONGetMemoryStats(mon, stats, nr_stats); - else + if (mon->json) { + ignore_value(qemuMonitorFindBalloonObjectPath(mon, mon->vm, "/")); + mon->ballooninit = true;

+ ret = qemuMonitorJSONGetMemoryStats(mon, mon->balloonpath, + stats, nr_stats); + } else { ret = qemuMonitorTextGetMemoryStats(mon, stats, nr_stats); + } return ret; }