Re: [libvirt] [PATCH] introducing <source> <name> (for logical storage pools)

On Fri, Aug 29, 2008 at 03:49:27PM -0400, David Lively wrote: > Hi Jim - > I've attached a (very) small incremental patch (i.e., to be applied > after the one you've already merged) that addresses a couple things I > noticed missing: > (a) documents the new <source> <name> element in formatstorage.html.in > (b) adds --source-name to the (optional) args for virsh pool-define-as > > I've also attached a new version of the full patch containing this > change, in case that's easier. Okidoc, I finally added this in CVS, i just had to do a bit of porting since the XPath lookup function have an extra argument, but nothing hard. I also changed some of the error message to provide more context because as Jim pointed out they were a bit too generic. thanks a lot ! Daniel