Re: [PATCH] remote: Make remote_daemon depend on qemu_protocol.h

On 7/20/22 10:41, He Zhe wrote: > We sometimes meet the following parallel compililation issue, since > remote_daemon depends on remote_protocol.h qemu_protocol.h and lxc_protocol.h, > which are usually generated due to remote_driver . > > | FAILED: src/virtnetworkd.p/remote_remote_daemon_dispatch.c.o > | x86_64-wrs-linux-gcc ... > | In file included from ../libvirt-8.1.0/src/remote/remote_daemon_dispatch.c:26: > | ../libvirt-8.1.0/src/remote/remote_daemon.h:30:10: fatal error: qemu_protocol.h: No such file or directory > | 30 | #include "qemu_protocol.h" > | | ^~~~~~~~~~~~~~~~~ > | compilation terminated. > > This patch adds the headers as dependencies of remote_daemon to make sure they > are always in place in advance. > > Signed-off-by: He Zhe <zhe.he(a)windriver.com&gt; > --- > src/remote/meson.build | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) Hm.. I'm failing to reproduce the build error, even though I put sleep(5) into both src/rpc/gendispatch.pl and src/rpc/genprotocol.pl and I try in a machine with 384 cores. I even wrapped rpcgen in a shell script to insert a short sleep. In the commit message you mention libvirt-8.1.0, does this problem still occurs even with the current master?

Michal