Re: [libvirt PATCH v2 11/17] qemu, hypervisor: refactor some cgroup mgmt methods
On 12/3/2021 11:38 AM, Ján Tomko wrote:
On a Thursday in 2021, Praveen K Paladugu wrote:
> Refactor some cgroup management methods from qemu into hypervisor.
> These methods will be shared by ch driver for cgroup management.
>
The QEMU driver fails to compile after this patch - it seems
qemu_process.c needs to include the header with the functions.
To get a build coverage for most of our supported platforms,
you can push into your private fork of the libvirt repo on gitlab.
The pipeline should run automatically.
Thanks for the pointer Jano. I fixed the build issue and also confirmed
majority of the builds pass in gitlab's CI.
Jano
> Signed-off-by: Praveen K Paladugu <prapal(a)linux.microsoft.com>
> ---
> src/hypervisor/domain_cgroup.c | 426 ++++++++++++++++++++++++++++++++-
> src/hypervisor/domain_cgroup.h | 52 ++++
> src/libvirt_private.syms | 10 +
> src/qemu/qemu_cgroup.c | 410 +------------------------------
> src/qemu/qemu_cgroup.h | 11 -
> src/qemu/qemu_driver.c | 14 +-
> src/qemu/qemu_hotplug.c | 4 +-
> src/qemu/qemu_process.c | 17 +-
> 8 files changed, 515 insertions(+), 429 deletions(-)
>
--
Regards,
Praveen K Paladugu