Re: [libvirt] [PATCH 19/20] qemuagenttest: Test arbitrary qemu commands and timeouting of commands

>> For that matter, 'make check' for day-to-day usage should be able to >> skip the gnulib subdirectory - the results in gnulib/tests will only >> change if you upgrade the gnulib submodule, glibc, or some other core >> component, which is not what we change on a day-to-day basis when >> hacking gnulib, but is also something an autobuilder should be running >> always. I'll see if I can hack something up to speed up 'make check' >> for normal users on the gnulib front, which we can then extend into >> skipping Peter's new test. > > Good idea to skip gnulib tests. > >> GNU coreutils calls its variable RUN_EXPENSIVE_TESTS, defaulting to no, >> but set to yes in autobuilders. Sounds like the best type of naming >> (maybe VIR_TEST_EXPENSIVE, to keep it in the VIR_ namespace). Anyone >> else want to chime in with a bikeshed color? > > That sounds like a fine name to me. I like it too.