Re: [PATCH] documentation: untrue statement in GetVersion() method description
On a Thursday in 2024, Stepan Zobal wrote:
In the end of virConnectGetVersion() description there is written:
"not with a Read-Only connection"
which isn't true after I tried virConnectOpenReadOnly() with virConnectGetVersion()
and it clearly shows the version correctly.
It seems this was true originally at the time of introduction in:
commit 96a54b42a64ffff90beaec2b7d5e883888c7c11b
CommitDate: 2005-12-08 13:26:52 +0000
* src/libvir.c src/libvir_sym.version src/xen_internal.[ch]
include/libvir.h: implementing hypervisor Version and Type interfaces
But then the ioctl getting the version was moved to the time of
initialization of the xend driver:
commit a2e2e4652f29c7acddec37c0b0f46c1179895d0e
CommitDate: 2006-06-21 12:15:18 +0000
* src/xen_internal.c: try to autodetect the Xen hypervisor version
used and switch automatically. A bit nasty though.
( And the whole xend driver was removed in 2018 by commit 1dac5fbbbb )
Signed-off-by: Stepan Zobal <szobal(a)redhat.com>
---
src/libvirt-host.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/libvirt-host.c b/src/libvirt-host.c
index e67b36812e..5030707bbf 100644
--- a/src/libvirt-host.c
+++ b/src/libvirt-host.c
@@ -180,8 +180,7 @@ virConnectGetType(virConnectPtr conn)
* @hvVer: return value for the version of the running hypervisor (OUT)
*
* Get the version level of the Hypervisor running. This may work only with
- * hypervisor call, i.e. with privileged access to the hypervisor, not
- * with a Read-Only connection.
+ * hypervisor call, i.e. with privileged access to the hypervisor.
The part about a privileged access to the hypervisor can be removed too.
Jano
*
* Returns -1 in case of error, 0 otherwise. if the version can't be
* extracted by lack of capacities returns 0 and @hvVer is 0, otherwise
--
2.46.0
Attachments:
- signature.asc (application/pgp-signature — 228 bytes)