Re: [libvirt] [libvirt-designer][PATCH v2 1/4] Load osinfo DB on init

> > >> + osinfo_loader = osinfo_loader_new(); >> + osinfo_loader_process_default_path(osinfo_loader, err); >> + if (err) >> + return FALSE; > > I'm not sure we want to error out there, see > http://git.fedorahosted.org/cgit/libosinfo.git/commit/?id=dbde512c3a64640... > for my reasoning (and you can try a "mkdir -p ~/.config/libosinfo/db && > echo '<bad' >~/.config/libosinfo/db/broken.xml" to get into a 'bad' > situation). IIUC, malformed XML doesn't affect loading of other well-formed XMLs, right? If this is the case, then yes - we should not report error. However, if malformed XML results in empty libosinfo DB, then we must report error here as non-empty DB is crucial for libvirt-designer.