Re: [libvirt] [PATCH] build: avoid build failure without polkit
On Mon, Jul 01, 2013 at 02:10:29PM -0600, Eric Blake wrote:
rpmbuild of mingw-libvirt.spec failed with:
GEN libvirt.syms
GEN libvirt_qemu.def
cat: libvirt_access.syms: No such file or directory
cat: libvirt_access_qemu.syms: No such file or directory
cat: libvirt_access_lxc.syms: No such file or directory
I traced this to unconditionally trying to use the ACL .syms files,
even when polkit isn't in use.
Hmm, really ? The methods in these .syms files are actually
methods that are inserted into all the driver method impls
unconditionally. So we shouldn't make this conditional on
polkit, rather we should fix the bug that causes them to
be unused when polkit is missing.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|