Re: [libvirt] [PATCH] Canonicalize qemu machine types
On Thu, Jul 23, 2009 at 01:56:21PM -0400, Cole Robinson wrote:
On 07/23/2009 01:34 PM, Mark McLoughlin wrote:
> Hey,
> Here's a series of patches to implement danpb's suggestion of
> using 'qemu -M ?' to probe for valid machine types and then to build
> on that for the machine type canonicalization.
>
What's the speed difference of GetCapabilities after these patches? Not
that it needs to be fast, but it would be useful to know if it's
slowwwwwwww.
Urgh, I forgot that that re-builds capabilities on every invocation :-(
It might be better to move the refresh into the SIGHUP handler, and
have an RPM %trigger against 'qemu' install to send libvirt SIGHUP
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|