Re: [libvirt] [Qemu-devel] [PATCH 3/3] ui: remove support for SDL1.2 in favour of SDL2
On Wed, Aug 08, 2018 at 02:51:01PM +0100, Peter Maydell wrote:
On 8 August 2018 at 11:49, Daniel P. Berrangé
<berrange(a)redhat.com> wrote:
> SDL1.2 was deprecated in the 2.12.0 release with:
>
> commit e52c6ba34149b4f39c3fd60e59ee32b809db2bfa
> Author: Daniel P. Berrange <berrange(a)redhat.com>
> Date: Mon Jan 15 14:25:33 2018 +0000
>
> ui: deprecate use of SDL 1.2 in favour of 2.0 series
>
> The SDL 2.0 release was made in Aug, 2013:
>
> https://www.libsdl.org/release/
>
> That will soon be 4 + 1/2 years ago, which is enough time to consider
> the 2.0 series widely supported.
>
> Thus we deprecate the SDL 1.2 support, which will allow us to delete it
> in the last release of 2018. By this time, SDL 2.0 will be more than 5
> years old.
>
> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau(a)redhat.com>
> Message-id: 20180115142533.24585-1-berrange(a)redhat.com
> Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com>
>
> It is thus able to be removed in the 3.1.0 release.
At least one of the BSD VMs in tests/vm/ is still using SDL1.2.
I think we should update that VM before we drop SDL1.2 support.
I confirmed that the freebsd & netbsd images still work as SDL just gets
automatically disabled by configure. The openbsd image breaks hard though
because SDL is the only available audio backend on openbsd, effectively
making SDL a mandatory requirement.
So we definitely need to update the openbsd image to have SDL2.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|