Re: [libvirt] [PATCH v2 4/5] qemu: Enforce ACPI, UEFI requirements

> @@ -2884,6 +2884,26 @@ qemuDomainDefValidate(const virDomainDef *def, >          goto cleanup; >      } >   > +    /* On x86, UEFI requires ACPI */ > +    if (def->os.loader && > +        def->os.loader->type == VIR_DOMAIN_LOADER_TYPE_PFLASH && > +        ARCH_IS_X86(def->os.arch) && > +        def->features[VIR_DOMAIN_FEATURE_ACPI] != VIR_TRISTATE_SWITCH_ON) { > +        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", > +                       _("UEFI requires ACPI on this architecture")); > +        goto cleanup; > +    } > + > +    /* On aarch64, ACPI requires UEFI */ > +    if (def->features[VIR_DOMAIN_FEATURE_ACPI] == VIR_TRISTATE_SWITCH_ON && > +        def->os.arch == VIR_ARCH_AARCH64 && > +        (!def->os.loader || > +         def->os.loader->type != VIR_DOMAIN_LOADER_TYPE_PFLASH)) { > +        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", > +                       _("ACPI requires UEFI on this architecture")); > +        return -1;   goto cleanup;

So as I said in my last response to v1 - are you sure there couldn't be a guest running that now disappears because of this check?   IOW should this move to post parse processing...   ACK - if you're positive this won't affect the running guest causing it to disappear.